Skip to content

[releases/29.x] Missing teaching tip on page 9852 (Effective Permissions) - an agent should be able to handle this - #10997

Merged
Onat Buyukakkus (onbuyuka) merged 1 commit into
releases/29.xfrom
bugs/648898-backport
Sep 4, 2026
Merged

[releases/29.x] Missing teaching tip on page 9852 (Effective Permissions) - an agent should be able to handle this#10997
Onat Buyukakkus (onbuyuka) merged 1 commit into
releases/29.xfrom
bugs/648898-backport

Conversation

@onbuyuka

@onbuyuka Onat Buyukakkus (onbuyuka) commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Backport of bug #638696 to releases/29.x.

Fixes AB#648898

Original PR: #10579

)

## What & why

Page 9852 (Effective Permissions) was missing a teaching tip, so users
opening the page got no in-product explanation of what "effective
permissions" are or how to use them. This adds the page-level
`AboutTitle` and `AboutText` properties so the page shows a teaching
tip, consistent with the sibling permission pages (e.g. Permission Set
by User, Permissions Overview, Permission Sets).

## Linked work

Fixes
[AB#638696](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/638696)

## How I validated this

- [x] I read the full diff and it contains only changes I intended.
- [x] I built the affected file locally with no new analyzer warnings.
- [ ] I ran the change in Business Central and confirmed it behaves as
expected.
- [x] I added or updated tests for the new behavior, or explained below
why none are needed.

**What I tested and the outcome**

- Change is limited to two static page metadata properties
(`AboutTitle`/`AboutText`) on page 9852, mirroring the exact pattern
used by neighboring pages in `System/Permissions`.
- Verified with the AL compiler (`al_getdiagnostics`) that
`EffectivePermissions.Page.al` compiles with **0 errors and 0 new
warnings** after the change. The only diagnostic on the file is a
pre-existing warning about `SourceTable = Permission` being marked for
removal, which is unrelated to this change.
- No tests added: teaching tips are static UI metadata
(`AboutTitle`/`AboutText`) with no logic to exercise, and sibling
permission pages that define the same properties have no dedicated
tests.

## Risk & compatibility

None. This is a metadata-only addition of a teaching tip; there is no
behavioral, data, permission, or upgrade impact. The strings are
translatable and will be picked up by the standard translation
extraction.

Copilot-Session: d77332c6-59ac-4ca4-b8f3-342b6baa5d33
@onbuyuka
Onat Buyukakkus (onbuyuka) requested a review from a team September 3, 2026 10:23
@onbuyuka
Onat Buyukakkus (onbuyuka) requested a review from a team as a code owner September 3, 2026 10:23
@github-actions github-actions Bot added the Team: Integrations GitHub request for Integrations area label Sep 3, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 3, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change adds AboutTitle and AboutText to page 9852, "Effective Permissions", so the page can show a teaching tip. The diff only adds static page metadata before the existing page behavior settings. This matches nearby permission pages and does not change triggers, permission calculations, data reads, or edit behavior.

Problem-solution fit

Fit: Strong

The bug says this page is missing a teaching tip, and the diff adds the requested page-level teaching-tip metadata. The scope is narrow and does not add unrelated behavior.

Suggestions

None.

Risk assessment and necessity

Risk: Low. The changed file only adds static UI metadata, with no change to permission logic, page triggers, data writes, public APIs, or event publishers. Nearby permission pages already use the same metadata pattern.

Necessity: The change is needed to add the missing in-product explanation for effective permissions. The two added properties match the requested title and text, and the scope is appropriate for a backport.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10997 round=1 by=alexei-dobriansky at=2026-09-04T08:44:26.9695747Z lastSha=1f0ad09c21f6cabcab63627898bfce4984d37389 reviewKey=b0bde50a49c7b970200ec922b633f709255ae919513ebc1a9cbc05701d9390ca suggestions=none

@onbuyuka
Onat Buyukakkus (onbuyuka) merged commit 915d72d into releases/29.x Sep 4, 2026
328 of 337 checks passed
@onbuyuka
Onat Buyukakkus (onbuyuka) deleted the bugs/648898-backport branch September 4, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants